feat(progress-bar): add recipe and tokens#31087
Open
thetaPC wants to merge 14 commits intoionic-modularfrom
Open
feat(progress-bar): add recipe and tokens#31087thetaPC wants to merge 14 commits intoionic-modularfrom
thetaPC wants to merge 14 commits intoionic-modularfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
commented
Apr 20, 2026
| subtle?: boolean; | ||
| } | ||
|
|
||
| export function ionColor(name: string, variation: string, options: IonColorOptions = {}): string { |
Contributor
Author
There was a problem hiding this comment.
This function is originally added through the badge PR but it's still in progress so I added it here to not be blocked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Component styles for
ion-progress-barare fragmented across multiple files (native andionic). Themdandiosthemes rely on the native styles. Developers were restricted to those themes and how those themes structured the logic and styles.What is the new behavior?
progress-bar.scssfile that consumes CSS variables, ensuring a single source of truth for component logic.IonProgressBartype and tokens to use an element-first hierarchy ({type}.{element}.{state}, e.g.,determinate.progress.default.background). This provides predictability and consistency with the rest of the system.progress-bar.interfaces.tswith reusable types for the recipe and config.ios,md, andionictheme files.roundandrectangularshape variants with per-theme defaults (roundforiosandionic,rectangularformd).buffer = 1), including separate rules for the buffer bar and buffer circles.progress-bar-type-determinate/progress-bar-type-indeterminate) to prevent cross-type style bleed.--backgroundand--progress-backgroundwith a structured set of semantic variables (e.g.,--ion-progress-bar-determinate-progress-default-background).Does this introduce a breaking change?
This PR introduces breaking changes to how
IonProgressBaris styled.Migration Path:
Token Updates: Update any custom theme configurations to match the new nested structure.
CSS Variable Replacements:
--backgroundand--progress-backgroundhave been removed. Use the new token structure instead:--background→IonProgressBar.determinate.buffer.bar.default.background(or the indeterminate equivalent)--progress-background→IonProgressBar.determinate.progress.default.background(or the indeterminate equivalent)If per-component customization is needed, the CSS variables can be used directly (e.g.,
--ion-progress-bar-determinate-progress-default-background).Host class names: The type classes on the host element have been renamed to include the prop name:
.progress-bar-determinate→.progress-bar-type-determinate.progress-bar-indeterminate→.progress-bar-type-indeterminateTheme classes: Remove any instances that target the theme classes:
ion-progress-bar.md,ion-progress-bar.ios.Other information
Previews:
Previews: